Skip to content

Fix bug when using postgresql 8.x #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2017
Merged

Fix bug when using postgresql 8.x #207

merged 2 commits into from
Feb 17, 2017

Conversation

tmclouisluk
Copy link
Contributor

@tmclouisluk tmclouisluk commented Feb 2, 2017 •
edited by loay
Loading

BUG: error: unterminated quoted string at or near "'\' ORDER BY "uuid""
when using like filter.
eg. { where: {name: {like: "%abc%"}}}

@slnode
Copy link

slnode commented Feb 2, 2017

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@slnode
Copy link

slnode commented Feb 2, 2017

Can one of the admins verify this patch?

2 similar comments
@slnode
Copy link

slnode commented Feb 2, 2017

Can one of the admins verify this patch?

@slnode
Copy link

slnode commented Feb 2, 2017

Can one of the admins verify this patch?

@loay
Copy link
Contributor

loay commented Feb 2, 2017

Hi @tmclouisluk
Thanks for your contribution.
Can you please sign the Individual Contributor License Agreement, so we can review this Pull request?
https://cla.strongloop.com/agreements/strongloop/loopback-connector-postgresql
Also, can you please add a unit test to ensure we catch any future regression? Thanks.

@loay loay added the team-apex label Feb 2, 2017
@tmclouisluk
Copy link
Contributor Author

Hi @loay
The CLA is done.

@loay
Copy link
Contributor

loay commented Feb 3, 2017

@slnode test please

@loay
Copy link
Contributor

loay commented Feb 3, 2017

Thanks @tmclouisluk
Looks good.
One more thing, can you please edit the commit message? One of the lines is longer that 72 characters and it is causing a test failure. Thanks.

@tmclouisluk
Copy link
Contributor Author

@loay
Oh, loay.
How to edit the committed commits?

@0candy
Copy link
Contributor

0candy commented Feb 13, 2017

@tmclouisluk Here are the steps to edit a commit message:
https://help.github.com/articles/changing-a-commit-message/

@kjdelisle kjdelisle assigned kjdelisle and dhmlau and unassigned kjdelisle and dhmlau Feb 15, 2017
@ssh24 ssh24 self-assigned this Feb 17, 2017
@tmclouisluk @ssh24
Fix bug when using postgresql 8.x
bf85c50 
BUG: error: unterminated quoted string at or near
\"'\\' ORDER BY \"uuid\"\" when using like filter.
eg. { where: {name: {like: "%abc%"}}}
@tmclouisluk @ssh24
Update postgresql.js
4cc326d
@ssh24
Copy link
Contributor

ssh24 commented Feb 17, 2017

@slnode test please

ssh24
ssh24 approved these changes Feb 17, 2017
View reviewed changes
Copy link
Contributor

@ssh24 ssh24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssh24 ssh24 merged commit e4078c5 into loopbackio:master Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssh24 ssh24 ssh24 approved these changes

Assignees

@ssh24 ssh24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tmclouisluk @slnode @loay @0candy @ssh24 @kjdelisle @crandmck @dhmlau