Add ILIKE functionality #194

alireza-ahmadi · 2016-12-15T10:35:16Z

Description

Loopback-datasource-juggler added support for ILIKE and NOT ILIKE functionality in v3.1.0, but the PostgreSQL connector does not update to support them. This pull request adds this functionality by adding a few lines to lib/postgresql.js file.

Related issues

Add ilike and nilike operators loopback-datasource-juggler#1091

Please let me if any other changes needed.

slnode · 2016-12-15T10:35:17Z

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

slnode · 2016-12-15T10:35:22Z

Can one of the admins verify this patch?

slnode · 2016-12-15T10:35:22Z

Can one of the admins verify this patch?

slnode · 2016-12-15T10:35:23Z

Can one of the admins verify this patch?

superkhau · 2016-12-15T17:29:09Z

Can you add some tests to verify your changes and prevent regressions in the future?

alireza-ahmadi · 2016-12-16T01:44:35Z

Yes, I will add a few test in the next few days.

zbarbuto · 2017-02-16T10:08:34Z

@alireza-ahmadi any news on this?

alireza-ahmadi · 2017-02-18T05:55:04Z

@zbarbuto @superkhau I have added a few tests for the added feature. Also because I couldn't find the required test for LIKE and NOT LIKE operators, I have added a few tests for them as well because I thought that all of these operators are pattern matching operators and are linked.

Please let me know if the tests don't have a good coverage or any other changes needed.

superkhau

Overall LGTM, a few minor nits to fix and we can land this. ;)

superkhau · 2017-02-20T22:19:58Z

test/postgresql.test.js

+      function(done) {
+        Post.find({where: {content: {like: '%TestCase%'}}},
+          function(err, posts) {
+            should.not.exists(err);


if (err) return done(err); for better stack traces

superkhau · 2017-02-20T22:20:16Z

test/postgresql.test.js

+      Post.destroyAll(done);
+    });
+
+    it('should support case sensitive queries using like',


it('supports case sensi...

Yes, I see the other tests are different (we need to eventually update all of them to this style over time

superkhau · 2017-02-20T22:21:00Z

test/postgresql.test.js

+          });
+      });
+
+    it('should not support case insensitive queries using like',


superkhau · 2017-02-20T22:21:06Z

test/postgresql.test.js

+      function(done) {
+        Post.find({where: {content: {like: '%tesTcasE%'}}},
+          function(err, posts) {
+            should.not.exists(err);


superkhau · 2017-02-20T22:21:10Z

test/postgresql.test.js

+          });
+      });
+
+    it('should support like for no match', function(done) {


superkhau · 2017-02-20T22:22:17Z

test/postgresql.test.js

+    it('should support ilike for no match', function(done) {
+      Post.find({where: {content: {ilike: '%tesTxasE%'}}},
+        function(err, posts) {
+          should.not.exists(err);


superkhau · 2017-02-20T22:22:21Z

test/postgresql.test.js

+        });
+    });
+
+    it('should support negative case insensitive queries using nilike',


superkhau · 2017-02-20T22:22:29Z

test/postgresql.test.js

+      function(done) {
+        Post.find({where: {content: {nilike: '%casE%'}}},
+          function(err, posts) {
+            should.not.exist(err);


superkhau · 2017-02-20T22:22:32Z

test/postgresql.test.js

+          });
+      });
+
+    it('should support nilike for no match', function(done) {


superkhau · 2017-02-20T22:22:36Z

test/postgresql.test.js

+    it('should support nilike for no match', function(done) {
+      Post.find({where: {content: {nilike: '%tesTxasE%'}}},
+        function(err, posts) {
+          should.not.exists(err);


alireza-ahmadi · 2017-02-21T12:50:20Z

@superkhau Thanks for the review, I have applied the requested changes. Please let me know if any other changes required.

superkhau · 2017-02-22T20:06:31Z

@slnode test please

superkhau · 2017-02-28T21:42:31Z

test/postgresql.test.js

+    });
+    after(function deleteTestFixtures(done) {
+      Post.destroyAll(done);
+    });


You can remove the after since we delete in the before already

@superkhau Thanks for the review. I will apply these changes, rebase, and push the changes in the next few minutes.

superkhau · 2017-02-28T21:43:50Z

test/postgresql.test.js

+        title: 't2',
+        content: 'T2_TheOtherCase',
+      }], done);
+    });


You can move the two functions to the bottom of the context block:

before(deleteTestFixtures); before(createTestFixtures); it('...'); it('...'); ... function deleteTestFixtures(done) { Post.destroyAll(done); } function create...

http://loopback.io//doc/en/contrib/style-guide.html#layout-of-test-files

superkhau

Approved with my last suggested fixed.

superkhau · 2017-02-28T21:45:24Z

@kjdelisle Reassigning to your squad.

- Change test descriptions to match the new style - Change error handling mechanism for better stack traces

alireza-ahmadi · 2017-02-28T22:31:48Z

I have applied the requested code style changes(and a typo in createTestFixtures) and rebased to the last state of master branch. Again, please let me know if any other changes required.

superkhau · 2017-02-28T22:39:15Z

Let's wait for CI to pass, should be good to land. TY for the contribution BTW. 🙇‍♂️

zbarbuto · 2017-02-28T22:47:58Z

Thanks for your effort @alireza-ahmadi

@superkhau Can we expect a new point release soon with this feature?

superkhau · 2017-03-01T00:33:06Z

@zbarbuto Can be released as soon as it lands. @kjdelisle will help you there once it passes CI -- I think it's hanging ATM now though. ;(

kjdelisle · 2017-03-01T16:20:29Z

@slnode test please

kjdelisle · 2017-03-02T15:17:56Z

LGTM

crandmck added the #community contribution label Dec 15, 2016

cgole removed the #community contribution label Jan 7, 2017

alireza-ahmadi force-pushed the feature/ilike branch from 4f2c0d6 to 3cb3fa1 Compare February 18, 2017 06:14

superkhau suggested changes Feb 20, 2017

View reviewed changes

alireza-ahmadi force-pushed the feature/ilike branch 2 times, most recently from 0db8b34 to 91c7a05 Compare February 22, 2017 21:42

superkhau approved these changes Feb 28, 2017

View reviewed changes

superkhau requested review from kjdelisle and removed request for kjdelisle February 28, 2017 21:44

superkhau assigned kjdelisle Feb 28, 2017

superkhau self-requested a review February 28, 2017 21:44

superkhau added the feature label Feb 28, 2017

superkhau approved these changes Feb 28, 2017

View reviewed changes

superkhau added the team-apex label Feb 28, 2017

alireza-ahmadi force-pushed the feature/ilike branch 2 times, most recently from eb6489a to c9bade4 Compare February 28, 2017 22:14

alireza-ahmadi added 3 commits March 1, 2017 01:56

Add ILIKE functionality

f44dddf

Add tests for pattern matching operators

5cbb4ab

Improve tests for better code style consistency

2706edd

- Change test descriptions to match the new style - Change error handling mechanism for better stack traces

Fix code style inconsistencies in ilike tests

7f3b4d6

alireza-ahmadi force-pushed the feature/ilike branch from c9bade4 to 7f3b4d6 Compare February 28, 2017 22:29

superkhau approved these changes Feb 28, 2017

View reviewed changes

kjdelisle added the needs-priority label Feb 28, 2017

kjdelisle assigned 0candy Feb 28, 2017

kjdelisle added review and removed needs-priority labels Feb 28, 2017

kjdelisle merged commit ff2dff0 into loopbackio:master Mar 2, 2017

kjdelisle removed the review label Mar 2, 2017

Add ILIKE functionality #194

Add ILIKE functionality #194

Uh oh!

Conversation

alireza-ahmadi commented Dec 15, 2016

Description

Related issues

Uh oh!

slnode commented Dec 15, 2016

Uh oh!

slnode commented Dec 15, 2016

Uh oh!

slnode commented Dec 15, 2016

Uh oh!

slnode commented Dec 15, 2016

Uh oh!

superkhau commented Dec 15, 2016

Uh oh!

alireza-ahmadi commented Dec 16, 2016

Uh oh!

zbarbuto commented Feb 16, 2017

Uh oh!

alireza-ahmadi commented Feb 18, 2017

Uh oh!

superkhau left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alireza-ahmadi commented Feb 21, 2017

Uh oh!

superkhau commented Feb 22, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

superkhau left a comment

Choose a reason for hiding this comment

Uh oh!

superkhau commented Feb 28, 2017

Uh oh!

alireza-ahmadi commented Feb 28, 2017

Uh oh!

superkhau commented Feb 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zbarbuto commented Feb 28, 2017

Uh oh!

superkhau commented Mar 1, 2017

Uh oh!

kjdelisle commented Mar 1, 2017

Uh oh!

kjdelisle commented Mar 2, 2017

Uh oh!

Uh oh!

superkhau commented Feb 28, 2017 •

edited

Loading