Skip to content

Update README with correct doc links, etc #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2016
Merged

Update README with correct doc links, etc #187

merged 1 commit into from
Nov 2, 2016

Conversation

Amir-61
Copy link
Contributor

@Amir-61 Amir-61 commented Nov 1, 2016

#* Update README with correct doc links, etc

/to: @superkhau @crandmck


The PostgreSQL Connector module for for [loopback-datasource-juggler](http://docs.strongloop.com/loopback-datasource-juggler/).
The PostgreSQL Connector module for [loopback-datasource-juggler](http://docs.strongloop.com/loopback-datasource-juggler/).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Note:

I could not find the equivalent of http://docs.strongloop.com/loopback-datasource-juggler/ in http://loopback.io/doc/en/lb2/

Could you help?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its supposed to connect to the Juggler repo like https://github.com/strongloop/loopback-connector-mysql/blame/master/README.md#L3. However, I think we should just change the entire sentence:

"The official PostgreSQL connector for the LoopBack framework" would suffice. See https://github.com/strongloop/loopback-connector-kv-redis#loopback-connector-kv-redis


The PostgreSQL Connector module for for [loopback-datasource-juggler](http://docs.strongloop.com/loopback-datasource-juggler/).
The PostgreSQL Connector module for [loopback-datasource-juggler](http://docs.strongloop.com/loopback-datasource-juggler/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its supposed to connect to the Juggler repo like https://github.com/strongloop/loopback-connector-mysql/blame/master/README.md#L3. However, I think we should just change the entire sentence:

"The official PostgreSQL connector for the LoopBack framework" would suffice. See https://github.com/strongloop/loopback-connector-kv-redis#loopback-connector-kv-redis

@superkhau superkhau removed their assignment Nov 1, 2016
@Amir-61 Amir-61 merged commit 188451f into master Nov 2, 2016
@Amir-61 Amir-61 deleted the edit_readme branch November 2, 2016 03:20
@Amir-61 Amir-61 removed the #review label Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants