Skip to content

gn build: Add check-builtins target. #134482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2025

Conversation

pcc
Copy link
Contributor

@pcc pcc commented Apr 5, 2025

Tested on aarch64 Linux and x86_64 Linux.

pcc and others added 2 commits April 4, 2025 22:07
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1

[skip ci]
@pcc pcc requested review from nico and aeubanks April 5, 2025 05:08
Created using spr 1.3.6-beta.1
Copy link
Contributor

@aeubanks aeubanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow this is very messy, feels like there should be a better way to do this on the CMake side

@pcc
Copy link
Contributor Author

pcc commented Apr 7, 2025

wow this is very messy, feels like there should be a better way to do this on the CMake side

Yeah, or maybe even in the tests themselves, maybe they should be using weak symbols for the builtins and return unsupported if the symbol is undefined at runtime.

llvmgnsyncbot and others added 2 commits April 7, 2025 13:22
Created using spr 1.3.6-beta.1

[skip ci]
Created using spr 1.3.6-beta.1
@pcc pcc changed the base branch from users/pcc/spr/main.gn-build-add-check-builtins-target to main April 7, 2025 20:22
@pcc pcc merged commit 9222607 into main Apr 7, 2025
6 of 11 checks passed
@pcc pcc deleted the users/pcc/spr/gn-build-add-check-builtins-target branch April 7, 2025 20:22
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Apr 7, 2025
Tested on aarch64 Linux and x86_64 Linux.

Reviewers: aeubanks, nico

Reviewed By: aeubanks

Pull Request: llvm/llvm-project#134482
@nico
Copy link
Contributor

nico commented Apr 17, 2025

This breaks llvm/utils/gn/build/sync_source_lists_from_cmake.py output, it still prints output like:

[gn build] Port 6d03f51f0c59 -- https://github.com/llvm/llvm-project/commit/6d03f51f0c59
  llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn
   add:
    "extendhfdf2.c",

@pcc
Copy link
Contributor Author

pcc commented Apr 17, 2025

Isn't that a new file? I would expect it to try to add it to the _unused set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants