Skip to content

Commit 2b133ec

Browse files
committed
[Tests] aria-role: add now-passing test
Fixes jsx-eslint#756.
1 parent 79b975a commit 2b133ec

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

__tests__/src/rules/aria-role-test.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,11 @@ ruleTester.run('aria-role', rule, {
7676
{ code: '<img role="presentation" />', options: ignoreNonDOMSchema },
7777
{
7878
code: '<Div role="button" />',
79-
errors: [errorMessage],
8079
settings: customDivSettings,
8180
},
81+
{
82+
code: '<svg role="graphics-document document" />',
83+
},
8284
].concat(validTests).map(parserOptionsMapper),
8385

8486
invalid: [

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
"license": "MIT",
7171
"dependencies": {
7272
"@babel/runtime": "^7.19.4",
73-
"aria-query": "^5.1.1",
73+
"aria-query": "^5.1.3",
7474
"array-includes": "^3.1.5",
7575
"ast-types-flow": "^0.0.7",
7676
"axe-core": "^4.5.0",

src/rules/aria-role.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ const schema = generateObjSchema({
2828
},
2929
});
3030

31+
const validRoles = new Set([...roles.keys()].filter((role) => roles.get(role).abstract === false));
32+
3133
export default {
3234
meta: {
3335
docs: {
@@ -41,7 +43,6 @@ export default {
4143
const options = context.options[0] || {};
4244
const ignoreNonDOM = !!options.ignoreNonDOM;
4345
const allowedInvalidRoles = new Set(options.allowedInvalidRoles || []);
44-
const validRoles = new Set([...roles.keys()].filter((role) => roles.get(role).abstract === false));
4546
const elementType = getElementType(context);
4647

4748
return ({

0 commit comments

Comments
 (0)