Skip to content

Commit 79b975a

Browse files
bmishljharb
authored andcommitted
[Docs] missing descriptions in some rules
1 parent 6d7a857 commit 79b975a

7 files changed

+17
-8
lines changed

.eslintrc

+1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
"files": ["src/rules/*"],
2222
"extends": ["plugin:eslint-plugin/rules-recommended"],
2323
"rules": {
24+
"eslint-plugin/require-meta-docs-description": ["error", { "pattern": "^(Enforce|Require|Disallow)" }],
2425
"eslint-plugin/require-meta-docs-url": [
2526
"error",
2627
{ "pattern": "https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/{{name}}.md" },

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ configuration file by mapping each custom component name to a DOM element type.
120120

121121
| Name                                          | Description | 💼 ||
122122
| :----------------------------------------------------------------------------------------------------------- | :--------------------------------------------------------------------------------------------------------------------------------- | :---- | :-- |
123-
| [accessible-emoji](docs/rules/accessible-emoji.md) | | ||
123+
| [accessible-emoji](docs/rules/accessible-emoji.md) | Enforce emojis are wrapped in `<span>` and provide screenreader access. | ||
124124
| [alt-text](docs/rules/alt-text.md) | Enforce all elements that require alternative text have meaningful information to relay back to end user. | ☑️ 🔒 | |
125125
| [anchor-ambiguous-text](docs/rules/anchor-ambiguous-text.md) | Enforce `<a>` text to not exactly match "click here", "here", "link", or "a link". | | |
126126
| [anchor-has-content](docs/rules/anchor-has-content.md) | Enforce all anchors to contain accessible content. | ☑️ 🔒 | |
@@ -139,7 +139,7 @@ configuration file by mapping each custom component name to a DOM element type.
139139
| [img-redundant-alt](docs/rules/img-redundant-alt.md) | Enforce `<img>` alt prop does not contain the word "image", "picture", or "photo". | ☑️ 🔒 | |
140140
| [interactive-supports-focus](docs/rules/interactive-supports-focus.md) | Enforce that elements with interactive handlers like `onClick` must be focusable. | ☑️ 🔒 | |
141141
| [label-has-associated-control](docs/rules/label-has-associated-control.md) | Enforce that a `label` tag has a text label and an associated control. | ☑️ 🔒 | |
142-
| [label-has-for](docs/rules/label-has-for.md) | | ||
142+
| [label-has-for](docs/rules/label-has-for.md) | Enforce that `<label>` elements have the `htmlFor` prop. | ||
143143
| [lang](docs/rules/lang.md) | Enforce lang attribute has a valid value. | | |
144144
| [media-has-caption](docs/rules/media-has-caption.md) | Enforces that `<audio>` and `<video>` elements must have a `<track>` for captions. | ☑️ 🔒 | |
145145
| [mouse-events-have-key-events](docs/rules/mouse-events-have-key-events.md) | Enforce that `onMouseOver`/`onMouseOut` are accompanied by `onFocus`/`onBlur` for keyboard-only users. | ☑️ 🔒 | |
@@ -153,7 +153,7 @@ configuration file by mapping each custom component name to a DOM element type.
153153
| [no-onchange](docs/rules/no-onchange.md) | Enforce usage of `onBlur` over `onChange` on select menus for accessibility. | ||
154154
| [no-redundant-roles](docs/rules/no-redundant-roles.md) | Enforce explicit role property is not the same as implicit/default role property on element. | ☑️ 🔒 | |
155155
| [no-static-element-interactions](docs/rules/no-static-element-interactions.md) | Enforce that non-interactive, visible elements (such as `<div>`) that have click handlers use the role attribute. | ☑️ 🔒 | |
156-
| [prefer-tag-over-role](docs/rules/prefer-tag-over-role.md) | | | |
156+
| [prefer-tag-over-role](docs/rules/prefer-tag-over-role.md) | Enforces using semantic DOM elements over the ARIA `role` property. | | |
157157
| [role-has-required-aria-props](docs/rules/role-has-required-aria-props.md) | Enforce that elements with ARIA roles must have all required attributes for that role. | ☑️ 🔒 | |
158158
| [role-supports-aria-props](docs/rules/role-supports-aria-props.md) | Enforce that elements with explicit or implicit roles defined contain only `aria-*` properties supported by that `role`. | ☑️ 🔒 | |
159159
| [scope](docs/rules/scope.md) | Enforce `scope` prop is only used on `<th>` elements. | ☑️ 🔒 | |

docs/rules/label-has-for.md

+7-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
# jsx-a11y/label-has-for
22

3-
❌ This rule is deprecated.
3+
❌ This rule is deprecated. It was replaced by [`label-has-associated-control`](label-has-associated-control.md).
44

55
💼 This rule is _disabled_ in the following configs: ☑️ `recommended`, 🔒 `strict`.
66

77
<!-- end auto-generated rule header -->
88

9-
*This rule was deprecated in v6.1.0. It will no longer be maintained. Please use [`label-has-associated-control`](label-has-associated-control.md) instead.*
9+
_This rule was deprecated in v6.1.0. It will no longer be maintained._
1010

1111
Enforce label tags have associated control.
1212

@@ -81,13 +81,15 @@ However, if `allowChildren` is set to `true`, no error will be raised. If you wa
8181
Note that passing props as spread attribute without `htmlFor` explicitly defined will cause this rule to fail. Explicitly pass down `htmlFor` prop for rule to pass. The prop must have an actual value to pass. Use `Label` component above as a reference. **It is a good thing to explicitly pass props that you expect to be passed for self-documentation.** For example:
8282

8383
#### Bad
84+
8485
```jsx
8586
function Foo(props) {
8687
return <label {...props} />
8788
}
8889
```
8990

9091
#### Good
92+
9193
```jsx
9294
function Foo({ htmlFor, ...props}) {
9395
return <label htmlFor={htmlFor} {...props} />
@@ -106,6 +108,7 @@ function Foo(props) {
106108
```
107109

108110
### Succeed
111+
109112
```jsx
110113
<label htmlFor="firstName">
111114
<input type="text" id="firstName" />
@@ -114,12 +117,14 @@ function Foo(props) {
114117
```
115118

116119
### Fail
120+
117121
```jsx
118122
<input type="text" id="firstName" />
119123
<label>First Name</label>
120124
```
121125

122126
## Accessibility guidelines
127+
123128
- [WCAG 1.3.1](https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships)
124129
- [WCAG 3.3.2](https://www.w3.org/WAI/WCAG21/Understanding/labels-or-instructions)
125130
- [WCAG 4.1.2](https://www.w3.org/WAI/WCAG21/Understanding/name-role-value)

src/rules/accessible-emoji.js

+1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ const schema = generateObjSchema();
2020
export default {
2121
meta: {
2222
docs: {
23+
description: 'Enforce emojis are wrapped in `<span>` and provide screenreader access.',
2324
url: 'https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/accessible-emoji.md',
2425
},
2526
deprecated: true,

src/rules/label-has-for.js

+2
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,9 @@ const getValidityStatus = (node, required, allowChildren, elementType) => {
8888
export default {
8989
meta: {
9090
deprecated: true,
91+
replacedBy: ['label-has-associated-control'],
9192
docs: {
93+
description: 'Enforce that `<label>` elements have the `htmlFor` prop.',
9294
url: 'https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/label-has-for.md',
9395
},
9496
schema: [schema],

src/rules/no-aria-hidden-on-focusable.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,13 @@ import getElementType from '../util/getElementType';
1212
import isFocusable from '../util/isFocusable';
1313
import { generateObjSchema } from '../util/schemas';
1414

15-
const errorMessage = 'aria-hidden="true" must not be set on focusable elements.';
1615
const schema = generateObjSchema();
1716

1817
export default {
1918
meta: {
2019
docs: {
2120
url: 'https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/no-aria-hidden-on-focusable.md',
22-
description: errorMessage,
21+
description: 'Disallow `aria-hidden="true"` from being set on focusable elements.',
2322
},
2423
schema: [schema],
2524
},
@@ -35,7 +34,7 @@ export default {
3534
if (isAriaHidden && isFocusable(type, attributes)) {
3635
context.report({
3736
node,
38-
message: errorMessage,
37+
message: 'aria-hidden="true" must not be set on focusable elements.',
3938
});
4039
}
4140
},

src/rules/prefer-tag-over-role.js

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ const getLastPropValue = (rawProp) => {
3535
export default {
3636
meta: {
3737
docs: {
38+
description: 'Enforces using semantic DOM elements over the ARIA `role` property.',
3839
url: 'https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/tree/HEAD/docs/rules/prefer-tag-over-role.md',
3940
},
4041
schema: [schema],

0 commit comments

Comments
 (0)