Add support for --proxy-domain #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI... the Jenkins build for code-server is broken. There are no linux-x86_64 assets since 3.2.0... code-server broke something. |
|
Yup, see #28 |
|
Hi, Are you guys planning on working this out? Thanks |
3 similar comments
|
I needed to merge in the latest changes, that's been done. This can be merged now. |
1 similar comment
aptalca
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We welcome all PR’s though this doesn’t guarantee it will be accepted.
Description:
Add --proxy-domain args to start args
Benefits of this PR and context:
code-server supports subdomain-based proxying of internal ports. In order to support this, the --proxy-domain arg needs to be set.
How Has This Been Tested?
Container built with this support and run. Redacted relevant log output here:
Source / References:
https://github.com/cdr/code-server/blob/master/doc/FAQ.md#sub-domains