Update Windows Scripts & Add Python 3 support for numpy init #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add numpy support for Python3.X
lava
requested changes
Dec 6, 2017
| #else | ||
| void init_numpy(){ | ||
| #endif | ||
| import_array() |
There was a problem hiding this comment.
Hi, sorry for the late review! The rest of the PR looks great, but I think this is missing a return 0; in the Python 3 case. It would be great if you could amend and force push this.
|
I think this was made obsolete by 037022b, so I'll be closing this. Anyways, as always, thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. build fails with clang, python3 and numpy 1.7.1 and higher pandas-dev/pandas#3872