Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Upgrade project to use latest version of electron-vue #93

Merged
merged 4 commits into from
Oct 7, 2019
Merged

Upgrade project to use latest version of electron-vue #93

merged 4 commits into from
Oct 7, 2019

Conversation

jack-chapman
Copy link
Contributor

This PR addresses #92 . A dependency updated automatically by dependabot caused problems for fresh installs.

This change should hopefully prevent that kind of thing from happening again soon 👍

Happy to make any changes!

@jack-chapman
Copy link
Contributor Author

I can remove the package-lock.json if it's a problem!

@lauthieb
Copy link
Owner

lauthieb commented Oct 2, 2019

Thanks @jack-chapman for this PR!
I will check that ASAP tomorrow :)

@jack-chapman
Copy link
Contributor Author

^ Looks like the Travis build might have broken because the newer electron-vue version needs node 8.x.x

lauthieb
lauthieb approved these changes Oct 6, 2019
View reviewed changes
Copy link
Owner

@lauthieb lauthieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this great PR!!! 🎉

@lauthieb
Copy link
Owner

lauthieb commented Oct 6, 2019

@jack-chapman maybe you can change the .travis.yml file to fit with a node version 8?

@lauthieb lauthieb mentioned this pull request Oct 6, 2019
Closed
@jack-chapman
Copy link
Contributor Author

@lauthieb I'll fix the Travis build and put the Vue version back up to 2.6 later on today (I didn't notice that had changed when doing the electron-vue update.

@lauthieb
Copy link
Owner

lauthieb commented Oct 7, 2019

Nice, thanks @jack-chapman !

@lauthieb
Copy link
Owner

lauthieb commented Oct 7, 2019

OK for me, OK for Travis, let's merge 🎉 @jack-chapman

@lauthieb lauthieb merged commit 8b53008 into lauthieb:master Oct 7, 2019
@lauthieb lauthieb mentioned this pull request Oct 7, 2019
Closed
@jack-chapman
Copy link
Contributor Author

Hooray 🎉

@TheFern2
Copy link
Contributor

TheFern2 commented Oct 7, 2019

Just FYI this branch broke the dev script.

npm run dev, before:

node .electron-vue/dev-runner.js

npm run dev, after:

NODE_ENV=development node .electron-vue/dev-runner.js

NODE_ENV is not recognized as an internal or external command.

@lauthieb
Copy link
Owner

lauthieb commented Oct 7, 2019

Hi @kodaman2, so what we could do?

@jack-chapman
Copy link
Contributor Author

@kodaman2 Have you run npm install to update your copy?

@lauthieb
Copy link
Owner

lauthieb commented Oct 7, 2019

If it's a problem about Windows, maybe we could use cross-env

@TheFern2
Copy link
Contributor

TheFern2 commented Oct 7, 2019

I was just trying to fix conflicts on my PR, and couldn't run dev, I just went back to the before, to be able to run npm run dev, not entirely sure why there is a NODE_ENV now, maybe @jack-chapman has a better idea or this was done automatically with the upgrade.

@TheFern2
Copy link
Contributor

TheFern2 commented Oct 7, 2019

@kodaman2 Have you run npm install to update your copy?

yes npm install was done, didn't have issues running dev before this merge btw, yes I am on windows. Is there some env variables I need to set now?

@lauthieb
Copy link
Owner

lauthieb commented Oct 7, 2019

Okay, I already encounter this problem. Windows doesn't understand this type of ENV variable declaration. I will use cross-env and make a PR now.

@lauthieb
Copy link
Owner

lauthieb commented Oct 7, 2019

image

@jack-chapman
Copy link
Contributor Author

Okay, I already encounter this problem. Windows doesn't understand this type of ENV variable declaration. I will use cross-env and make a PR now.

Apologies for this, I didn't realise windows does not recognise this type of ENV variable.

@lauthieb
Copy link
Owner

lauthieb commented Oct 7, 2019

Here is my fix: #99, can you try?

@TheFern2
Copy link
Contributor

TheFern2 commented Oct 7, 2019

Here is my fix: #99, can you try?

Yes, fix worked! 😀

@lauthieb
Copy link
Owner

lauthieb commented Oct 7, 2019

Thanks @kodaman2 for your answer.
Merged!

@lauthieb
Copy link
Owner

lauthieb commented Nov 2, 2019

Here is the new release 1.2.3 of Code Notes : https://github.com/lauthieb/code-notes/releases/tag/1.2.3 🎉
Congrats @kodaman2!

@TheFern2 TheFern2 mentioned this pull request Nov 9, 2019
Closed
@TheFern2 TheFern2 mentioned this pull request Dec 3, 2019
Merged
kartik-budhiraja pushed a commit to kartik-budhiraja/code-notes that referenced this pull request Dec 8, 2019
@jack-chapman @kartik-budhiraja
Upgrade project to use latest version of electron-vue (lauthieb#93)
480055d 
* Update to use newest version of electron-vue

* Fix issue with templates not compiling - vue-loader

* Revert Vue version

* Change travis node version to 8.x.x
stephengroat pushed a commit to stephengroat/code-notes that referenced this pull request Dec 9, 2019
@jack-chapman @stephengroat-dd
Upgrade project to use latest version of electron-vue (lauthieb#93)
ac37457 
* Update to use newest version of electron-vue

* Fix issue with templates not compiling - vue-loader

* Revert Vue version

* Change travis node version to 8.x.x
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lauthieb lauthieb lauthieb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jack-chapman @lauthieb @TheFern2