Skip to content
This repository was archived by the owner on Feb 2, 2025. It is now read-only.

Add missing dependency datatables.net-dt in bower for releases >=0.5.5; #964

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Add missing dependency datatables.net-dt in bower for releases >=0.5.5; #964

merged 1 commit into from
Feb 7, 2017

Conversation

roldevg
Copy link

@roldevg roldevg commented Feb 7, 2017

Hi!
I found that bug, when tried zero configuration example with release 0.5.5 and bower;
With release 0.5.4 or NPM it's all ok!

How to reproduce?

  1. bower i angular-datatables#0.5.5
  2. Create code from example http://l-lin.github.io/angular-datatables/archives/#/zeroConfig
    Add to index.html scripts and css:
  • <script src="bower_components/jquery/dist/jquery.min.js"></script>
  • <script src="bower_components/datatables.net/media/js/jquery.dataTables.min.js"></script>
  • <script src="bower_components/angular/angular.min.js"></script>
  • <script src="bower_components/angular-datatables/dist/angular-datatables.min.js"></script>
  • <>link rel="stylesheet" href="bower_components/angular-datatables/dist/css/angular-datatables.css">

Problem:
Styles on table incorrect, missing jquery.dataTables.min.css styles.
It is important to add on page.
BUT Missing datatables.net-dt/media/jquery.dataTables.min.css from dependencies.

How to fix?

  • add to bower.json "datatables.net-dt": ">=1.10.9",

Missing datatables.net-dt/media/jquery.dataTables.min.css from dependencies.
@l-lin l-lin merged commit dea3247 into l-lin:angular1 Feb 7, 2017
@l-lin
Copy link
Owner

l-lin commented Feb 7, 2017

👍

you're awesome

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants