Skip to content
This repository was archived by the owner on Feb 2, 2025. It is now read-only.

Adding support for Light Column Filter #431

Merged
merged 1 commit into from
Sep 2, 2015
Merged

Adding support for Light Column Filter #431

merged 1 commit into from
Sep 2, 2015

Conversation

ertogs
Copy link

@ertogs ertogs commented Sep 2, 2015

Hope this is done right :)

Please note: These files changed after running "grunt" :
/src/angular-datatables-renderer.js
/src/plugins/bootstrap/angular-datatables.bootstrap.js

I do not know why. Please have an eye on them.

@l-lin l-lin merged commit a78864d into l-lin:dev Sep 2, 2015
l-lin added a commit that referenced this pull request Sep 2, 2015
@l-lin
Copy link
Owner

l-lin commented Sep 2, 2015

Awesome 👍

On a side note:

The command grunt is also formatting the code. Maybe because we are not on the same plateform that it formats differently? (I'm on Xubuntu)

You do not need to add the code dtOptionsBuilderDecorator.$inject = ['$delegate']; as ng-annotate is doing this for us when compiling the project.

@l-lin l-lin added this to the v0.5.0 milestone Sep 2, 2015
@ertogs
Copy link
Author

ertogs commented Sep 2, 2015

Great it worked 👍
I am on OSX, so maybe that is the reason.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants