Skip to content
This repository was archived by the owner on Feb 2, 2025. It is now read-only.

[Feature] Angular Schematics update #1543

Merged
merged 3 commits into from
May 9, 2021

Conversation

shanmukhateja
Copy link
Collaborator

  1. Fixes duplicate entries to angular.json when ng add is run several times.
  2. Adds support for skipping modification to angular.json and package.json when not needed
  3. Adds prompt for choosing styling library with ng add1.

1. The end-user needs to install and configure Bootstrap CSS on their project before installing this library for changes to take affect.

@shanmukhateja shanmukhateja requested a review from l-lin May 8, 2021 11:38
Copy link
Owner

@l-lin l-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on fresh angular app and is working as expected.

@l-lin l-lin merged commit aa1564c into l-lin:master May 9, 2021
@shanmukhateja shanmukhateja deleted the feat-schematics-update branch May 9, 2021 10:51
shanmukhateja added a commit to shanmukhateja/angular-datatables that referenced this pull request Jul 11, 2021
* feat(schematics): skip adding package.json deps if already exist

* feat: move angular.json update code to utils

* feat(schematics): Add support for choosing styling library
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants