This repository was archived by the owner on Feb 2, 2025. It is now read-only.
FIX regexp #100
Closed
FIX regexp #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regexp being used fails if the datatable is not initialised with empty data. When the table is empty, we try to match an expression that looks like this : `<!-- ngRepeat: v in a.b --><!-- end ngRepeat: v in a.b -->` ngRepeatAttr is then correctly matched to `a.b` When the table is NOT empty, then the expression looks more like this : `<!-- ngRepeat: v in a.b --><tr ng-repeat="v in a.b" class="ng-scope">...` ngRepeatAttr is then set to `a.b"` (with a quote at the end of the expression) We should use a `.+?` as a non-greedy version of `.+` to match only the expression inside the comment
|
Awesome! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regexp being used fails if the datatable is not initialised with empty data.
When the table is empty, we try to match an expression that looks like this :
<!-- ngRepeat: v in a.b --><!-- end ngRepeat: v in a.b -->ngRepeatAttr is then correctly matched to
a.bWhen the table is NOT empty, then the expression looks more like this :
<!-- ngRepeat: v in a.b --><tr ng-repeat="v in a.b" class="ng-scope">...ngRepeatAttr is then set to
a.b"(with a quote at the end of the expression)We should use a
.+?as a non-greedy version of.+to match only the expression inside the comment