Skip to content
This repository was archived by the owner on Feb 2, 2025. It is now read-only.

The bower install did not edit the index.html file #65

Closed
stephaneeybert opened this issue Aug 28, 2014 · 4 comments
Closed

The bower install did not edit the index.html file #65

stephaneeybert opened this issue Aug 28, 2014 · 4 comments

Comments

@stephaneeybert
Copy link

It usually is the case that the bower install also edits the app/index.html file. Not so with this module. As Also I could not find the jquery and datatable includes in my app/index.html file. So I didnæt really know how to add the JS file as stated in the warning message: "You must include the JS file AFTER jQuery and DataTables!" of the getting started page.

l-lin added a commit that referenced this issue Aug 28, 2014
@l-lin
Copy link
Owner

l-lin commented Aug 28, 2014

I don't think bower install will add the dependency to your app/index.html.
You will need something like grunt-wiredep.

However, I noticed that grunt-wiredep will add every file set in the main properties of bower.json. I made some change so that only one file is include in the index.html. (Thanks for that btw 👍 )

Back to your issue, if you use grunt-wiredep, the dependency are included before angular-datatables when using grunt bower-install.

@stephaneeybert
Copy link
Author

Hi Lin, thanks for the fast feedback ! I never used the grunt-wiredep command. As a newbie grunt, bower and AngularJS user, that the "bower install" command edits my app/install.html file to add the necessary include file, usually one file indeed. Will that also be the case with your module ?

@l-lin
Copy link
Owner

l-lin commented Aug 28, 2014

Well I tried to use directly bower install, it does not include any file to any index.html. It's logical since there are no configuration as to where bower should include the dependency.
Check my gif that shows using grunt-wiredep:

grunt-bower-install

For a good start, I suggest you to look at yeoman and the generator-angular. They are used to generate an angular project.

@stephaneeybert
Copy link
Author

Thanks Lin. I'm too much of a beginner on this to bother you further. Thanks for the animated gif !

@l-lin l-lin closed this as completed Aug 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants