Skip to content
This repository was archived by the owner on Feb 2, 2025. It is now read-only.

DTColumnBuilder.newColumn('id', $translate('id')) not working #440

Closed
dranovsk opened this issue Sep 11, 2015 · 1 comment
Closed

DTColumnBuilder.newColumn('id', $translate('id')) not working #440

dranovsk opened this issue Sep 11, 2015 · 1 comment
Labels
Milestone

Comments

@dranovsk
Copy link

Hello Louis,

With addition of
if (angular.isString(sTitle)) {
column.sTitle = sTitle;
}
in DTColumnBuilder.newColumn,
newColumn('id', $translate('id')) is not working anymore - isString(Promise),
got to use newColumn('id', $translate.instant('id'))

withTtile($translate('id')) works fine.

Is it an intended change, please advise.

Thank you!

@l-lin l-lin added the bug label Sep 11, 2015
@l-lin l-lin added this to the v0.5.1 milestone Sep 11, 2015
@l-lin
Copy link
Owner

l-lin commented Sep 11, 2015

It was not intended. Thanks for reporting! 👍

@l-lin l-lin closed this as completed Sep 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants