Skip to content
This repository was archived by the owner on Feb 2, 2025. It is now read-only.

set 'destroy' of undefined #235

Closed
reinhardholl opened this issue Mar 3, 2015 · 5 comments
Closed

set 'destroy' of undefined #235

reinhardholl opened this issue Mar 3, 2015 · 5 comments
Labels
Milestone

Comments

@reinhardholl
Copy link

Hey.

Firstly, awesome plugin, using it in most of my projects! :)

I get this issue when I don't set a dt-options ex:
<table datatable="ng">

I had a quick look and it seems there is no default options object passed to renderDataTable
https://github.com/l-lin/angular-datatables/blob/master/src/angular-datatables.renderer.js#L45 causing options.destroy = true; to fail.

If this is the expected behaviour please ignore this issue.

Thanks again!

@l-lin
Copy link
Owner

l-lin commented Mar 3, 2015

Nope, that's not the expected behaviour.
Thanks for noticing it 👍

@l-lin l-lin added the bug label Mar 3, 2015
@l-lin l-lin added this to the v0.4.2 milestone Mar 3, 2015
@reinhardholl
Copy link
Author

No problem! :)

@jheffreyespino
Copy link

Waiting for 0.4.2 release :D

1 similar comment
@jheffreyespino
Copy link

Waiting for 0.4.2 release :D

@dmoore62
Copy link

Thanks for addressing that issue. Pulled 0.4.2 and it resolved my error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants