Skip to content
This repository was archived by the owner on Feb 2, 2025. It is now read-only.

Re-render of the table in Angular "ng" mode shows unrendered table #1299

Closed
rhorenov opened this issue Aug 31, 2018 · 0 comments
Closed

Re-render of the table in Angular "ng" mode shows unrendered table #1299

rhorenov opened this issue Aug 31, 2018 · 0 comments

Comments

@rhorenov
Copy link

I'm submitting a...


[x] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Question

For AngularJS version.

Current behavior

Re-render of the table in Angular "ng" mode does not hide the content while destroying the table.

This results in the un-rendered table being shown briefly on re-render, potentially on any change of the underlying data. This looks ugly.

Expected behavior

I'm proposing an easy fix. Angular-datatables already have DTRendererService.showLoading() method, which could be used to hide the table content just before the datatable gets destroyed.

Minimal reproduction of the problem with instructions

It can be demonstrated on the Demo page - Changing data with the Angular way, just try to delete a row.

Actions

I will submit a pull request with my proposed fix shortly.

Environment


- node version: v8.9.4
- angular version: 1.7.3
- angular-cli version:
- jquery version: 3.3.1
- datatables version: 1.10.15
- angular-datatables version: v0.6.3
rhorenov pushed a commit to rhorenov/angular-datatables that referenced this issue Aug 31, 2018
l-lin added a commit that referenced this issue Sep 1, 2018
Fix for #1299: Ugly Re-render in Angular "ng" mode.
@l-lin l-lin closed this as completed Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants