Skip to content

Add hakman as a reviewer #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2023
Merged

Add hakman as a reviewer #830

merged 1 commit into from
Dec 15, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Oct 8, 2023 •
edited
Loading

I'd like to help out with NPD as a reviewer.

  • Member for at least 3 months
  • Primary reviewer for at least 5 PRs to the codebase (reviews)
  • Reviewed or merged at least 20 substantial PRs to the codebase (reviews + contributions and testing).
  • Knowledgeable about the codebase

/cc @vteratipally @Random-Liu

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2023
@hakman
Copy link
Member Author

hakman commented Oct 8, 2023

/test pull-npd-e2e-node

@hakman
Copy link
Member Author

hakman commented Oct 18, 2023

Please let me know if there's any objection to merging this PR.
/assign @andyxning @wangzhen127 @xueweiz @vteratipally.
/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims October 18, 2023 10:44
@dims
Copy link
Member

dims commented Oct 18, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023
@vteratipally
Copy link
Collaborator

Thank you for your contribution.
/cc @Random-Liu

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hakman, vteratipally

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9f639dd into kubernetes:master Dec 15, 2023
@hakman hakman deleted the reviewer-chacman branch December 15, 2023 14:39
@hakman
Copy link
Member Author

hakman commented Dec 15, 2023

Thanks @Random-Liu! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@vteratipally vteratipally Awaiting requested review from vteratipally

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@vteratipally vteratipally

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @dims @vteratipally @k8s-ci-robot