Skip to content

Update docker build and fix ARM64 image #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2023
Merged

Update docker build and fix ARM64 image #801

merged 1 commit into from
Sep 14, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Sep 1, 2023 •
edited
Loading

Closes: #797

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 1, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 1, 2023
@hakman hakman changed the title WIP Fix docker build for multi-arch Fix docker build for multi-arch Sep 1, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2023
@hakman hakman changed the title Fix docker build for multi-arch Update docker build and fix ARM64 image Sep 1, 2023
@hakman
Copy link
Member Author

hakman commented Sep 1, 2023

/cc @MartinForReal @vteratipally

pacoxu
pacoxu reviewed Sep 6, 2023
View reviewed changes
@hakman
Copy link
Member Author

hakman commented Sep 7, 2023

/test pull-npd-e2e-node

1 similar comment
@hakman
Copy link
Member Author

hakman commented Sep 8, 2023

/test pull-npd-e2e-node

@hakman hakman force-pushed the fix-docker-build branch 4 times, most recently from 437c2a8 to d5a424a Compare September 8, 2023 20:50
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2023
@hakman
Copy link
Member Author

hakman commented Sep 14, 2023

@tzneal @vteratipally Could you take one more look? Thanks!

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 14, 2023
@hakman
Copy link
Member Author

hakman commented Sep 14, 2023

/test pull-npd-e2e-node

2 similar comments
@hakman
Copy link
Member Author

hakman commented Sep 14, 2023

/test pull-npd-e2e-node

@hakman
Copy link
Member Author

hakman commented Sep 14, 2023

/test pull-npd-e2e-node

@hakman
Copy link
Member Author

hakman commented Sep 14, 2023

Tests are now passing consistently, especially since kubernetes/test-infra#30710 was merged.

@hakman hakman requested review from tzneal and pacoxu September 14, 2023 16:21
@vteratipally
Copy link
Collaborator

/lgtm
/approve

Thank you for the fix.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, vteratipally

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 79ffff8 into kubernetes:master Sep 14, 2023
@pacoxu
Copy link
Member

pacoxu commented Sep 15, 2023

@vteratipally k/k tried to upgrade to the last release of NPD and reverted due to this issue. Will NPD release a new version in recent days? Or what is the release plan of NPD?

@hakman hakman deleted the fix-docker-build branch September 15, 2023 05:58
@vteratipally
Copy link
Collaborator

We can release a new version this week to fix the issue

@hakman
Copy link
Member Author

hakman commented Sep 15, 2023

@vteratipally @pacoxu maybe we want #814 too in the release, to be on the same Go version as k/k.

@hakman hakman mentioned this pull request Oct 4, 2023
Closed
@pacoxu pacoxu mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@xueweiz xueweiz Awaiting requested review from xueweiz

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

@vteratipally vteratipally Awaiting requested review from vteratipally

@tzneal tzneal Awaiting requested review from tzneal

@pacoxu pacoxu Awaiting requested review from pacoxu

Assignees

@vteratipally vteratipally

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exec format error on arm64
5 participants
@hakman @vteratipally @k8s-ci-robot @pacoxu @tzneal