-
Notifications
You must be signed in to change notification settings - Fork 655
Improve docs for health checker and system stats configs #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @dobesv! |
Hi @dobesv. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -102,8 +102,13 @@ certain backends. Some of them can be disabled at compile-time using a build tag | |||
|
|||
* `--config.custom-plugin-monitor`: List of paths to custom plugin monitor config files, comma-separated, e.g. | |||
[config/custom-plugin-monitor.json](https://github.com/kubernetes/node-problem-detector/blob/master/config/custom-plugin-monitor.json). | |||
Node problem detector will start a separate custom plugin monitor for each configuration. You can | |||
Node problem detector will start a separate custom plugin monitor for each configuration. You can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR.
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dobesv, vteratipally The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/remove approve |
I hope this change will clarify how to setup the health checkers, as I was confused about this - there was no documentation or example to follow here.
This also adds a link to the system stats config in the problem daemon types table, for convenience.