-
Notifications
You must be signed in to change notification settings - Fork 655
Change to using new dependency name for osreleaser #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To do this I 1. changed the name in go.mod and the Go code that used it, 2. ran `go mod tidy -go=1.15` and 3. ran `go mod vendor`. Step 3 added another vendored dependency unrelated AFAIK to this change.
Welcome @mx-psi! |
Hi @mx-psi. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm /ok-to-test |
Friendly ping. I'd like to see this merged. |
Anything I can do to get this merged? |
/ok-to-test |
/lgtm |
It seems unlikely to me that the failing tests are related to the contents of this PR. Can someone with more knowledge of the project assess if these are related and, if so, how to fix them? cc @tallclair ? |
@mx-psi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mx-psi, vteratipally The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Changes
github.com/cobaugh/osrelease
tojiasu.xzqcsaa.nyc.mn/acobaugh/osrelease
.Fixes #626.
Additional notes
To do this I
go mod tidy -go=1.15
andgo mod vendor
.Step 3 added another vendored dependency unrelated AFAIK to this change.