Windows Support: Fix Build Regressions, Tests Pass #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/sig windows |
k8s-ci-robot
added
sig/windows
Random-Liu
reviewed
Jan 29, 2021
k8s-ci-robot
added
size/L
jeremyje
changed the title
|
/retest |
Random-Liu
reviewed
Feb 17, 2021
|
Ping, we cannot build Windows NPD yet until this goes in. |
|
Weekly ping, Windows NPD is blocked on this change. |
Random-Liu
reviewed
Mar 13, 2021
|
Thanks for the review. Answered questions in the code changes itself. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeremyje, Random-Liu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cc @chardch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a build regression on Windows where some Linux specific logic in syscall package was used.
This change also adds the new Linux and Windows binaries to the critical path of of the test-infra CI. The new locations are more friendly to multi-arch builds.