Add multiarch support and docker manifests

[Sh4d1]

Fixes #135

This is #250 rebased on master with some additional fixes to make it work. (I was planning on making a PR on the fork of @mkumatag but he has to rebase his branch in ordre to merge it so creating a new PR sounded easier. (So most of the work was done by @mkumatag 😅)

Fixes: kubernetes/kubernetes#73364

[k8s-ci-robot]

Welcome @Sh4d1!

It looks like this is your first PR to kubernetes/node-problem-detector 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/node-problem-detector has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Sh4d1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Sh4d1]

@Random-Liu @dchen1107 possible to get an ok to test?

[mkumatag]

/ok-to-test

[Sh4d1]

Hmm it seems the failure are quite random 🤔

[Sh4d1]

So blocked by kubernetes/test-infra#14091 for now

[Sh4d1]

@andyxning so according to kubernetes/test-infra#14091 we need to setup GCB. Is this okay? If yes I'll add a cloudbuild.yaml and submit a PR to test-infra as well as creating a bucket on k8s.gcr.io.

[Sh4d1]

@dchen1107 @Random-Liu I'll ping you too 😅

[Sh4d1]

So I'll setup gcb and cross compiling next week :)

[Sh4d1]

It seems really hard to do it in Prow (can't statically cross-compile thanks to go-systemd). I'll try to get some GCB runners for this project!

[Sh4d1]

Once kubernetes/test-infra#16790 is merged, it should be good to go
/cc @xueweiz

[xueweiz]

Thanks for the explanation! I have never done multiarch work before, so I need to do some homework to learn about how other k8s projects support this.

Cross build does not work so we need to use qemu, and to do so we need to use cloubuild :)

This is the part I would need to learn more about :) Do you know any other k8s projects doing similar thing? If so, could you provide some reference (Makefile, PR, etc)? Then I could study them as a reference.

Thanks!

[Sh4d1]

I've done quite the same with kubernetes-sigs/apiserver-network-proxy#38 and kubernetes-sigs/metrics-server#467

Not sure how other are doing it (iirc I took some inspiration from another k8s project, but can't recall which one 😅 )

Cross build is not working with npd because of systemd dependencies and some CGO code.

But the basics of multi arch is to build each arch and then create a docker manifest (with the docker manifest) command and just push it :)

[xueweiz]

This is great! Thanks for the pointers. I'll update (hopefully soon) when I finishes the homework.

/assign @xueweiz

[Sh4d1]

Just ping if you have any questions 😄

[mkumatag]

@Random-Liu @xueweiz all good for you?
/cc @mkumatag

code seems okay to me,

[nvtkaszpir]

fixes #135

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sh4d1
To complete the pull request process, please assign xueweiz
You can assign the PR to them by writing /assign @xueweiz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@Sh4d1: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci-npd-e2e-test	7849b49	link	/test ci-npd-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Sh4d1]

@xueweiz any news?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[k8s-ci-robot]

@Sh4d1: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nvtkaszpir]

/remove-lifecycle stale

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.