Skip to content

Explicitly include libsystemd0 in the image. #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Nov 29, 2018

Fixes #232.

libsystemd0 was excluded from the base image kubernetes/kubernetes#69995

Explicitly include libsystemd0 because we need it for npd.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 29, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2018
@wangzhen127
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Random-Liu,wangzhen127]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 515b854 into kubernetes:master Nov 29, 2018
@Random-Liu Random-Liu deleted the include-libsystemd branch November 29, 2018 22:23
@Atoms
Copy link

Atoms commented Nov 30, 2018

can you release fix image ? :)

@Random-Liu
Copy link
Member Author

Random-Liu commented Nov 30, 2018

@Atoms Yeah, I'll do it next Monday, just to make sure there are no other issues coming out. :)

@chadswen
Copy link
Member

chadswen commented Jan 2, 2019

@Atoms Yeah, I'll do it next Monday, just to make sure there are no other issues coming out. :)

/cc @andyxning @wangzhen127 @Random-Liu now that #233 and #246 are merged, can we get that 0.6.2 release? Thanks!

@andyxning
Copy link
Member

/cc @Random-Liu Seems 0.6.2 is needed.

@wangzhen127
Copy link
Member

Just released: https://github.com/kubernetes/node-problem-detector/releases/tag/v0.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants