Skip to content

More fix to custom plugin monitor condition change #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2018
Merged

More fix to custom plugin monitor condition change #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/custompluginmonitor/custom_plugin_monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,10 @@ func (c *customPluginMonitor) generateStatus(result cpmtypes.Result) *types.Stat

condition.Status = status
condition.Reason = result.Rule.Reason
} else if condition.Status == status && condition.Message != result.Message {
// change 4: Condition status do not change. condition message changes.
} else if condition.Status == status && condition.Reason != result.Rule.Reason {
// change 4: Condition status do not change. condition reason changes.
condition.Transition = timestamp
condition.Reason = result.Rule.Reason
condition.Message = result.Message
events = append(events, util.GenerateConditionChangeEvent(
condition.Type,
Expand Down