-
Notifications
You must be signed in to change notification settings - Fork 655
chore: update golang.org/x/crypto and net deps #1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: daveoy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @daveoy. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
/test pull-npd-e2e-test |
CI is saying it needs a |
Hmm, running |
I have the same experience. Could be related to #1012? |
/retest |
2 similar comments
/retest |
/retest |
Error from presubmit failure
@daveoy have you run |
It's been saying that for 2 months... do I have access to inspect and modify the ci configs? |
Yeah, I wonder if we need to rerun it given several other PRs have been merged already. Many don't have the problem. But some automated ones also have this. I wonder if this is related to multiple PRs merging in parallel. |
let me see if i can figure this out locally |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
closing this to reopen @wangzhen127 |
@daveoy: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@wangzhen127 #1035 replacement PR |
Thanks! |
should close #994