Skip to content

chore: update golang.org/x/crypto and net deps #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

daveoy
Copy link
Contributor

@daveoy daveoy commented Jan 9, 2025

should close #994

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daveoy
Once this PR has been reviewed and has the lgtm label, please assign yujuhong for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from klueska January 9, 2025 19:52
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 9, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @daveoy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 9, 2025
@daveoy daveoy mentioned this pull request Jan 9, 2025
@wangzhen127
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 19, 2025
@wangzhen127
Copy link
Member

/retest

@daveoy
Copy link
Contributor Author

daveoy commented Jan 21, 2025

/test pull-npd-e2e-test

@daveoy
Copy link
Contributor Author

daveoy commented Jan 21, 2025

CI is saying it needs a go mod tidy....

@wangzhen127
Copy link
Member

Hmm, running go mod tidy locally does not make any change to any files.

@daveoy
Copy link
Contributor Author

daveoy commented Jan 21, 2025

I have the same experience. Could be related to #1012?

@wangzhen127
Copy link
Member

/retest

2 similar comments
@wangzhen127
Copy link
Member

/retest

@wangzhen127
Copy link
Member

/retest

@wangzhen127
Copy link
Member

Error from presubmit failure

Failed to compile metriconly:
go: updates to go.mod needed; to update it:
	go mod tidy

@daveoy have you run go mod tidy?

@daveoy
Copy link
Contributor Author

daveoy commented Mar 10, 2025

CI is saying it needs a go mod tidy....

It's been saying that for 2 months... do I have access to inspect and modify the ci configs?

@wangzhen127
Copy link
Member

Yeah, I wonder if we need to rerun it given several other PRs have been merged already. Many don't have the problem. But some automated ones also have this. I wonder if this is related to multiple PRs merging in parallel.

@daveoy
Copy link
Contributor Author

daveoy commented Mar 10, 2025

let me see if i can figure this out locally

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@daveoy
Copy link
Contributor Author

daveoy commented Mar 10, 2025

closing this to reopen @wangzhen127

@daveoy daveoy closed this Mar 10, 2025
@k8s-ci-robot
Copy link
Contributor

@daveoy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-npd-test a3c3c1e link true /test pull-npd-test
pull-npd-e2e-kubernetes-gce-gci-custom-flags a3c3c1e link true /test pull-npd-e2e-kubernetes-gce-gci-custom-flags
pull-npd-e2e-test a3c3c1e link true /test pull-npd-e2e-test
pull-npd-e2e-kubernetes-gce-ubuntu a3c3c1e link true /test pull-npd-e2e-kubernetes-gce-ubuntu
pull-npd-e2e-kubernetes-gce-gci a3c3c1e link true /test pull-npd-e2e-kubernetes-gce-gci
pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags a3c3c1e link true /test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags
pull-npd-build a3c3c1e link true /test pull-npd-build
pull-npd-verify-gomod a3c3c1e link true /test pull-npd-verify-gomod
pull-npd-e2e-node a3c3c1e link true /test pull-npd-e2e-node

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@daveoy
Copy link
Contributor Author

daveoy commented Mar 10, 2025

@wangzhen127 #1035 replacement PR

@wangzhen127
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIGH CVE in v0.8.20
3 participants