Skip to content

Commit d1a701c

Browse files
committed
add links to tests and rollback signals
Signed-off-by: Sally O'Malley <[email protected]>
1 parent 2489afe commit d1a701c

File tree

1 file changed

+17
-1
lines changed
  • keps/sig-instrumentation/2831-kubelet-tracing

1 file changed

+17
-1
lines changed

keps/sig-instrumentation/2831-kubelet-tracing/README.md

+17-1
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,12 @@ Alpha
230230

231231
- [X] Implement tracing of incoming and outgoing gRPC, HTTP requests in the kubelet
232232
- [X] Integration testing of tracing
233+
- _component-base tracing/api/v1 integration test_ https://github.com/kubernetes/kubernetes/blob/master/test/integration/apiserver/tracing/tracing_test.go
234+
- [X] Unit testing of kubelet tracing and tracing configuration
235+
- https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/config/validation/validation_test.go#L503-#L532
236+
- https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/cri/remote/remote_runtime_test.go#L65-#L97
237+
- https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/server/options/tracing_test.go
238+
- https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-base/tracing/api/v1/config_test.go
233239

234240
Beta
235241

@@ -299,7 +305,17 @@ _This section must be completed when targeting beta graduation to a release._
299305
No impact to running workloads, logs will indicate the problem.
300306

301307
###### What specific metrics should inform a rollback?
302-
To be determined.
308+
309+
* This KEP is following the [opentelemetry-go issue #2547](https://github.com/open-telemetry/opentelemetry-go/issues/2547).
310+
311+
```
312+
...using the OTLP trace exporter, it isn't currently possible to monitor (with metrics) whether or not spans are being successfully collected and exported.
313+
For example, if my SDK cannot connect to an opentelemetry collector, and isn't able to send traces, I would like to be able to measure how many traces are collected,
314+
vs how many are not sent. I would like to be able to set up SLOs to measure successful trace delivery from my applications.
315+
```
316+
317+
* Pod Lifecycle and Kubelet [SLOs](https://github.com/kubernetes/community/tree/master/sig-scalability/slos) are the signals that should guide a rollback. In particular, the [`kubelet_pod_start_duration_seconds_count`, `kubelet_runtime_operations_errors_total`, and `kubelet_pleg_relist_interval_seconds_bucket`] would surface issues affecting kubelet performance.
318+
303319

304320
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
305321
Upgrades and rollbacks will be tested while feature-gate is experimental

0 commit comments

Comments
 (0)