Skip to content

Commit 2489afe

Browse files
committed
update approver & connected spans section
Signed-off-by: Sally O'Malley <[email protected]>
1 parent 30e1830 commit 2489afe

File tree

2 files changed

+10
-6
lines changed
  • keps
    • prod-readiness/sig-instrumentation
    • sig-instrumentation/2831-kubelet-tracing

2 files changed

+10
-6
lines changed

keps/prod-readiness/sig-instrumentation/2831.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ kep-number: 2831
22
alpha:
33
approver: "@ehashman"
44
beta:
5-
approver: "@ehashman"
5+
approver: "@wojtek-t"
66

keps/sig-instrumentation/2831-kubelet-tracing/README.md

+9-5
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,10 @@ OpenTelemetry-Go provides the [propagation package](https://github.com/open-tele
143143

144144
### Connected Traces with Nested Spans
145145

146-
Nested spans with top-level traces in the kubelet will connect CRI calls together. Nested spans will be created for the following:
146+
With the initial implementation of this proposal, kubelet tracing produced disconnected spans, because context was not wired through kubelet CRI calls.
147+
With [this PR](https://github.com/kubernetes/kubernetes/pull/113591), context is now plumbed between CRI calls and kubelet.
148+
It is now possible to connect spans for CRI calls. Nested spans with top-level traces in the kubelet will connect CRI calls together.
149+
Nested spans will be created for the following:
147150
* Sync Loops (e.g. syncPod, eviction manager, various gc routines) where the kubelet initiates new work.
148151
* [top-level traces for pod sync and GC](https://github.com/kubernetes/kubernetes/pull/114504)
149152
* Incoming requests (exec, attach, port-forward, metrics endpoints, podresources)
@@ -233,11 +236,12 @@ Beta
233236
- [X] OpenTelemetry reaches GA
234237
- [X] Publish examples of how to use the OT Collector with kubernetes
235238
- [X] Allow time for feedback
236-
- [] Add top level traces to connect spans in sync loops, incoming requests, and outgoing requests.
237-
- [] Unit/integration test to verify connected traces in kubelet.
238-
- [] Revisit the format used to export spans.
239-
- [] Parity with the old text-based Traces
239+
- [ ] Add top level traces to connect spans in sync loops, incoming requests, and outgoing requests.
240+
- [ ] Unit/integration test to verify connected traces in kubelet.
241+
- [ ] Revisit the format used to export spans.
242+
- [ ] Parity with the old text-based Traces
240243
- [ ] Connecting traces from container runtimes via the Container Runtime Interface
244+
- https://github.com/kubernetes/kubernetes/pull/114504
241245

242246
GA
243247

0 commit comments

Comments
 (0)