-
Notifications
You must be signed in to change notification settings - Fork 63
disable unions, since they're still experimental #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lavalamp
commented
Aug 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, not sure why you did it this way, I don't really want to have this for a long time, wouldn't it have been easier to jusk skip the tests?
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
configObject, err = configObject.NormalizeUnionsApply(configObject) | ||
if err != nil { | ||
return nil, fieldpath.ManagedFields{}, err | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, you forgot one just below (yes, we call it before AND after merging)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't just skip the tests because if the code is checked in, it needs to not bitrot. Otherwise I need to delete it. |
That's fair |