stop exporting jsoniter based apis

[BenTheElder]

see: #202

TODO: should we bump the module to v6 since this removes APIs?

I can't find evidence that anyone else was using these:

none in the org:
https://cs.k8s.io/?q=(ReadJSONIter)%7C(WriteJSONStream)&i=nope&literal=nope&files=&excludeFiles=vendor&repos=

only in vendor/:
https://grep.app/search?f.lang=Go&regexp=true&q=%28ReadJSONIter%29%7C%28WriteJSONStream%29

[BenTheElder]

TODO: should we bump the module to v6 since this removes APIs?

Yes, because apidiff fails :-)

[k8s-ci-robot]

@BenTheElder: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-structured-merge-diff-apidiff	046e0a3	link	false	/test pull-structured-merge-diff-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[BenTheElder]

NOTE: apidiff now fails because the module version was bumped.
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_structured-merge-diff/288/pull-structured-merge-diff-apidiff/1913310145010470912

I could see an argument for either way.

/assign @jpbetz

[jpbetz]

/approve
/lgtm
I agree this worth bumping major version for.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jpbetz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liggitt]

let's wait to tag a v6 release until we're sure we've made all the public API changes we need?

edit: ha... too late... no big deal, numbers are cheap if we need a v7

[BenTheElder]

let's wait to tag a v6 release until we're sure we've made all the public API changes we need?

These are the only places that directly reference jsoniter in the public API.
I think it makes sense to proactively drop this (and mark it) to prevent any adoption from consumers.

For actually switching libraries, it's possible we could need changes elsewhere due to not having a clear path to implement with another library, but I think that'd be a last resort and seems unlikely...?