Skip to content

Add apidiff to prevent accidental breaking changes #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yongruilin opened this issue Dec 18, 2024 · 3 comments
Closed

Add apidiff to prevent accidental breaking changes #276

yongruilin opened this issue Dec 18, 2024 · 3 comments
Assignees
@yongruilin

Comments

@yongruilin
Copy link
Contributor

https://pkg.go.dev/golang.org/x/exp/apidiff can be used to determines whether two examples of a package or module are compatible. We can add a script and run it against this repo to prevent incompatible changes. Then potentially tune it to be a blocking presubmit job.
@yongruilin
Copy link
Contributor Author

/assign

@yongruilin yongruilin mentioned this issue Dec 18, 2024
Merged
@yongruilin yongruilin mentioned this issue Jan 13, 2025
Merged
@yongruilin yongruilin mentioned this issue Jan 21, 2025
Merged
@yongruilin
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@yongruilin: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yongruilin yongruilin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@k8s-ci-robot @yongruilin