-
Notifications
You must be signed in to change notification settings - Fork 63
Add go mod verify script and pre-submit #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
/help |
@jpbetz: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Alternatively, could we drop vendor from this repo? cc @Jefftree |
Created a PR to remove vendor. #272 It seems more convenient than having to remember to vendor every time + adding additional CI scripts. |
Can we close this issue? Vendor has been removed by #272 |
Sounds good. /close |
@Jefftree: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
go.mod should not be allowed to fall out of sync with vendor/modules.txt.
A hack/verify-vendor.sh style script should be added and then a verify presubmit should be added that calls this verify script.
The text was updated successfully, but these errors were encountered: