-
Notifications
You must be signed in to change notification settings - Fork 84
derive controller name from prototype and allow custom name #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
derive controller name from prototype and allow custom name #415
Conversation
Welcome @guillaume86! |
Hi @guillaume86. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks for your contribution! As the /ok-to-test |
/lgtm Very nice, thank you for contributing! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guillaume86, tomasaschan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR add a new InitWithName function that allow passing in a custom controller name, and changes the default name to be inferred from the prototype when possible.
Special notes for your reviewer:
It's my first contribution and first time with Go so reviews are welcome.
Additional documentation:
Change should simple enough to be self explanatory.