Skip to content

Add implicit ListVolumesResponse#Entry pagination limit #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pwschuurman
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR implicitly sets a pagination limit to 500 when ListVolumesRequest#max_entries is not set. gRPC institutes an maximum limit on received data size. In order to support clients (external-attacher) that have this restriction, return only 500 entries when ListVolumeRequest#max_entries is not set (0 value). This used to be the behavior of this function, prior to #813

Which issue(s) this PR fixes:
Fixes #998

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Enforce implicit pagination limit of 500 of the ListVolumesResponse#Entry field when ListVolumesRequest#max_entries is not set

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 21, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @pwschuurman. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from mattcary and saad-ali May 21, 2022 01:02
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 21, 2022
@pwschuurman pwschuurman force-pushed the list-volumes-response-implicit-entry-limit branch from 84d4249 to a80ed6b Compare May 21, 2022 01:06
@pwschuurman
Copy link
Contributor Author

/assign @mattcary

@mattcary
Copy link
Contributor

mattcary commented Jun 6, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit fda5a33 into kubernetes-sigs:master Jun 6, 2022
k8s-ci-robot added a commit that referenced this pull request Jun 14, 2022
…99-upstream-release-1.7

Automated cherry pick of #999: Add implicit ListVolumesResponse#Entry pagination limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit ListVolumesResponse to be within CSI response limitations
3 participants