Update deployment for 1.24 and 1.25 #989
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
| - psp_linux.yaml | ||
| - psp_windows.yaml | ||
| transformers: | ||
| - ../../images/stable-master |
| # Don't change stable image without changing pdImagePlaceholder in | ||
| # test/k8s-integration/main.go | ||
| newName: k8s.gcr.io/cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver | ||
| newTag: "v1.4.0" |
There was a problem hiding this comment.
let's use the updated image?
There was a problem hiding this comment.
ah.. good point. But which version? Go back to 1.3.6 or up to 1.6.0 which still has the node death problem?
There was a problem hiding this comment.
Maybe we can keep it as is. We will soon cut a new release with fix (1.7)
| @@ -5,5 +5,4 @@ namespace: | |||
| resources: | |||
| - cluster_setup.yaml | |||
| - controller.yaml | |||
| - psp.yaml | |||
There was a problem hiding this comment.
this change in base also means stable-1.23, stable-1.22, stable-1.21 wont have the psp. in this PR we are adding psp to the 1.24 overlay. should we consistent (i.e either remove psp from all 1.21 and beyond or keep psp in 1.21, 1.22, 1.23, 1.24 and removed from 1.25) ?
There was a problem hiding this comment.
Arg, you're absolutely right, good catch.
I think we should add it to the old ones so that stable-master is most simple.
Change-Id: I694842d570567faf879897d35c4516b2bfd74759
k8s-ci-robot
added
size/L
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary, saikat-royc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold Until I test this on 1.21 & 1.22 clusters. @saikat-royc if you want to remove the hold and lgtm so we can get the other fix out, please go ahead. |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Tested working on 1.21 |
Moving to Kubernetes 1.25 means that everything using policy/v1beta1 api will fail. The upstream works is done here: kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#989 but it looks like only the "stable-master" base is actually dropping PSPs.
/kind cleanup
What this PR does / why we need it:
Update overlay to work for 1.25 master, and make 1.24 overlay.
As part of this change, the PSP is removed from the master deployment, and for the 1.21-1.23 clusters added via customize. The noauth, debug and dev overlays do not have the PSP deployment as they are supposed to be tracking master.
Tested by doing deploy-driver with stable-1-24 on a e2e-up from a 1.24 head, and stable-master from k/k head (two weeks after 1.24 cut, so basically 1.25). (tests for the other versions are in-progress).
/assign @saikat-royc