-
Notifications
You must be signed in to change notification settings - Fork 159
Remove workaround to add os.version to the manifest for Windows images #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workaround to add os.version to the manifest for Windows images #986
Conversation
/cc @saikat-royc |
/retest |
/retest |
1 similar comment
/retest |
/lgtm |
@mattcary could you please approve this PR too? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
…86-upstream-release-1.7 Automated cherry pick of #986: Remove workaround to add os.version to the manifest for
What type of PR is this?
/kind bug
What this PR does / why we need it:
It looks like a recent version of docker in CI is adding
os.version
so the workaround to add it on our own is no longer needed, this was causing a doubleos.version
to be added to the manifest as seen here:I'm commenting the part that performs the text replacement, if this works then eventually this file and its usages should be removed.
Which issue(s) this PR fixes:
Ref #982
Does this PR introduce a user-facing change?:
/assign @saikat-royc