-
Notifications
You must be signed in to change notification settings - Fork 159
Add Makefile target that validates the Dockerfile images contain the correct shared library dependencies #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Makefile target that validates the Dockerfile images contain the correct shared library dependencies #985
Conversation
Hi @pwschuurman. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @saikat-royc |
@@ -0,0 +1,23 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this to verify-all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add in a later CL. We need kubernetes/test-infra#26312 to go through in order for Docker commands to be supported in verify-all.sh
f554eeb
to
cc19e49
Compare
…correct shared library dependencies
cc19e49
to
46d7e4a
Compare
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary, pwschuurman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind test
What this PR does / why we need it: This uses ldd on the target architecture (amd64/arm64) to validate if all direct and indirect dependencies of a program. The underlying logic leverages ldd to find dependencies that are "not found". This is helpful to catch in presubmit issues where all the runtime libs were not included. See #974 as an example of this.
Does this PR introduce a user-facing change?: