Skip to content

override maxprocs, defaulting to 1 #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2022
Merged

override maxprocs, defaulting to 1 #969

merged 1 commit into from
Apr 29, 2022

Conversation

mattcary
Copy link
Contributor

/kind bug
Which issue(s) this PR fixes:
Fixes #968

Default to MAXPROCS=1 to improve memory usage on nodes with many CPUs.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2022
@mattcary
Copy link
Contributor Author

/assign @amacaskill

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2022
@amacaskill
Copy link
Member

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2022
@mattcary
Copy link
Contributor Author

Looks like prow project doesn't have cmek permission.

/retest

@k8s-ci-robot k8s-ci-robot merged commit 36bb163 into kubernetes-sigs:master Apr 29, 2022
mattcary added a commit to mattcary/gcp-compute-persistent-disk-csi-driver that referenced this pull request Jul 18, 2022
@mattcary
Backport kubernetes-sigs#969 to release-1.3
4ba1ad7 
Change-Id: I0cc0db7c5988fbdd555b2116402bcc81b60b1fc6
@mattcary mattcary mentioned this pull request Jul 18, 2022
Merged
mattcary added a commit that referenced this pull request Jul 18, 2022
@mattcary
Merge pull request #1022 from mattcary/maxproc-backport
819cd2d 
Backport maxprocs (#969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@amacaskill amacaskill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory usage increasing with # cpus, especially with go1.17
3 participants
@mattcary @k8s-ci-robot @amacaskill