Run snapshot class tests separately from other tests #966
Conversation
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
|
/hold I'll want to examine the CI test run to make sure it's working as expected. |
k8s-ci-robot
added
the
do-not-merge/hold
|
Still timing out, will have to see what's getting run |
|
I don't understand ginkgo focus very well I guess; I think we have to basically ignore the passed in focus if there is a snapshot class given and use the volume snapshot feature. I'll have to double-check that's what we want here. |
mattcary
force-pushed
the
snap-tests
branch
3 times, most recently
from
639f17e to
32d3c97
Compare
|
/hold cancel finally it looks right! @leiyiz can you take a look & lgtm? |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/assign @leiyiz |
test/k8s-integration/main.go
Outdated
|
|
||
| focus := testParams.testFocus | ||
| skip := testParams.testSkip | ||
| if testParams.snapshotClassFile == "" && !strings.Contains(skip, "VolumeSnapshotDataSource") { |
There was a problem hiding this comment.
I think if the snapshotClassFile is not set, the k/k integration framework would not run snapshot tests? is that not the case
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Running all snapshot classes with all storage class is causing timeouts. Running the snapshot tests with just one storageclass does not substantially reduce the test coverage.
/kind failing-test