Skip to content

Add functionality to make architecture specific builds #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 3, 2022
Merged

Add functionality to make architecture specific builds #963

merged 6 commits into from
May 3, 2022

Conversation

dannawang0221
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #944

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 19, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @DW2022511. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 19, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 19, 2022
@dannawang0221
Copy link
Contributor Author

/assign @leiyiz

@dannawang0221
Copy link
Contributor Author

@pwschuurman

pwschuurman
pwschuurman reviewed Apr 19, 2022
View reviewed changes
dannawang0221
dannawang0221 commented Apr 21, 2022
View reviewed changes
test/e2e/tests/setup_e2e_test.go Outdated
@@ -34,6 +34,8 @@ import (

var (
project = flag.String("project", "", "Project to run tests in")
architecture = flag.String("arch", "amd64", "Architecture pd csi driver build on")
vmName = flag.String("vm-name", "", "Name of the VM to run tests on")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pwschuurman I run the t2a test, and we need to make vmName as flag as well.

leiyiz
leiyiz reviewed Apr 21, 2022
View reviewed changes
@leiyiz
Copy link
Contributor

leiyiz commented Apr 21, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2022
@dannawang0221 dannawang0221 force-pushed the danna/944-architecture branch from 74f2c33 to 59275d3 Compare April 23, 2022 02:50
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2022
pwschuurman
pwschuurman reviewed Apr 25, 2022
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 26, 2022
pwschuurman
pwschuurman approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@pwschuurman pwschuurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/remote/instance.go Outdated
}
}

if _, err := i.computeService.Instances.Get(i.project, i.zone, newInst.Name).Do(); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just check of curInst (or instance) is nil here? I don't think you need an extra Get call. This will also make your API response handling more consistent (right now you're using the first and second parameter in the return call to indicate the same semantics)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@dannawang0221
Copy link
Contributor Author

/assign @saikat-royc
/assign @mattcary
This PR should be ready to merge can you take a look?

@mattcary
Copy link
Contributor

mattcary commented May 2, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DW2022511, mattcary, pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 075128b into kubernetes-sigs:master May 3, 2022
mauriciopoppe
mauriciopoppe reviewed May 4, 2022
View reviewed changes
Makefile
@@ -41,8 +41,12 @@ gce-pd-driver: require-GCE_PD_CSI_STAGING_VERSION
go build -mod=vendor -gcflags=$(GCFLAGS) -ldflags "-X main.version=$(STAGINGVERSION)" -o bin/${DRIVERBINARY} ./cmd/gce-pd-csi-driver/

gce-pd-driver-windows: require-GCE_PD_CSI_STAGING_VERSION
ifeq (GOARCH, amd64)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this broke builds of the windows binary in https://prow.k8s.io/job-history/gs/kubernetes-jenkins/logs/ci-gce-pd-csi-driver-latest-k8s-master-windows-2019 (see the recent failures in about 7m), should it be $(GOARCH) instead?

W0504 14:19:19.035] #0 0.160 Makefile:48: gcp-pd-driver-windows only supports amd64.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm attempting to fix this in #973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauriciopoppe mauriciopoppe mauriciopoppe left review comments

@leiyiz leiyiz leiyiz left review comments

@pwschuurman pwschuurman pwschuurman approved these changes

@mattcary mattcary Awaiting requested review from mattcary

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@mattcary mattcary

@leiyiz leiyiz

@saikat-royc saikat-royc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add E2E test flags to specify machine type, zone, OS image, architecture
7 participants
@dannawang0221 @k8s-ci-robot @leiyiz @mattcary @mauriciopoppe @pwschuurman @saikat-royc