Skip to content

Add flags to specify zone/machine-type/OS image #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2022
Merged

Add flags to specify zone/machine-type/OS image #962

merged 1 commit into from
Apr 22, 2022
+20 −23

Conversation

dannawang0221
Copy link
Contributor

@dannawang0221 dannawang0221 commented Apr 14, 2022 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #944

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 14, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 14, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: DW2022511 / name: DW2022 (d6b468f)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 14, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @DW2022511!

It looks like this is your first PR to kubernetes-sigs/gcp-compute-persistent-disk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gcp-compute-persistent-disk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @DW2022511. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 14, 2022
@leiyiz
Copy link
Contributor

leiyiz commented Apr 14, 2022 •
edited
Loading

/assign @leiyiz

1 similar comment
@leiyiz
Copy link
Contributor

leiyiz commented Apr 14, 2022

/assign @leiyiz

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 14, 2022
leiyiz
leiyiz reviewed Apr 14, 2022
View reviewed changes
Copy link
Contributor

@leiyiz leiyiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested out your change?

test/e2e/tests/setup_e2e_test.go
@@ -35,6 +36,9 @@ import (
var (
project = flag.String("project", "", "Project to run tests in")
serviceAccount = flag.String("service-account", "", "Service account to bring up instance with")
zones = flag.String("zones", "us-central1-c,us-central1-b", "Zones to run tests in. If there are multiple zones, separate each by comma")
machine = flag.String("machine", "n1-standard-1", "Type of machine to provision instance on")
imageURL = flag.String("image-url", "projects/debian-cloud/global/images/family/debian-11", "OS image url to get image from")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we have moved to distroless, do we need to change to that here too? @pwschuurman

@leiyiz
Copy link
Contributor

leiyiz commented Apr 14, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2022
@dannawang0221
Copy link
Contributor Author

Link of the ticket #944 This PR add flags for zone/machine-type/OS image. Will add functionality to make architecture specific builds in another PR.

@dannawang0221
Copy link
Contributor Author

/assign @pwschuurman

@k8s-ci-robot
Copy link
Contributor

@DW2022511: GitHub didn't allow me to assign the following users: pwschuurman.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @pwschuurman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dannawang0221
Copy link
Contributor Author

I run the tests on this page and all pass https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/docs/local-development.md @pwschuurman do I want to test the change against GKE cluster?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 15, 2022
@pwschuurman
Copy link
Contributor

pwschuurman commented Apr 18, 2022 •
edited
Loading

LGTM

Can you update the comment to reference "/kind cleanup", and referrence #944 in the "Fixes" section?

@dannawang0221
Copy link
Contributor Author

/retest

1 similar comment
@dannawang0221
Copy link
Contributor Author

/retest

@dannawang0221
Copy link
Contributor Author

LGTM

Can you update the comment to reference "/kind cleanup", and referrence #944 in the "Fixes" section?

@leiyiz can you approve this PR? Thanks.

@leiyiz
Copy link
Contributor

leiyiz commented Apr 21, 2022

can you squash the commits into 1 commit?

@dannawang0221
Copy link
Contributor Author

@leiyiz done

leiyiz
leiyiz reviewed Apr 21, 2022
View reviewed changes
Copy link
Contributor

@leiyiz leiyiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2022
@leiyiz
Copy link
Contributor

leiyiz commented Apr 21, 2022

/approve

@leiyiz
Copy link
Contributor

leiyiz commented Apr 21, 2022 •
edited
Loading

seems like I don't have approval power for this repo. @mattcary can you take a look at this pr

@mattcary
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DW2022511, leiyiz, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit a6419b6 into kubernetes-sigs:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwschuurman pwschuurman pwschuurman left review comments

@leiyiz leiyiz leiyiz left review comments

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

Assignees

@leiyiz leiyiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add E2E test flags to specify machine type, zone, OS image, architecture
5 participants
@dannawang0221 @k8s-ci-robot @leiyiz @pwschuurman @mattcary