Skip to content

Cherry-pick of #929 #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2022
Merged

Cherry-pick of #929 #955

merged 3 commits into from
Apr 1, 2022

Conversation

mattcary
Copy link
Contributor

@mattcary mattcary commented Apr 1, 2022

/kind bug

Fix bug in original disk-image implementation that was fixed in test PR

luohao and others added 3 commits April 1, 2022 12:27
@luohao @mattcary
Fix image creation and clone
cef533c 
This patch fixed two issues in image creation and clone:
- add forceCreate flag to avoid image creation failures when source disk
  is attached
- fix the missing content source in CreateVolume response when restoring
  an image
@luohao @mattcary
Add e2e and integration tests for image snapshot
084aefe
@luohao @mattcary
fixup: append snapshotclass name to driver name
2c9984f
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2022
@pwschuurman
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@pwschuurman: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mattcary mattcary merged commit 633e466 into kubernetes-sigs:release-1.5 Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattcary @k8s-ci-robot @pwschuurman @luohao