Skip to content

cherrypick #943 - Return error when queued #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2022
Merged

cherrypick #943 - Return error when queued #951

merged 1 commit into from
Mar 30, 2022

Conversation

saikat-royc
Copy link
Member

@saikat-royc saikat-royc commented Mar 30, 2022 •
edited
Loading

Change-Id: Ia4933278dba561697abccff8a6e0bc8ab0b98cc4

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This fix is needed in this feature testing branch to make the next set of changes for backoff logic fix
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@mattcary @saikat-royc
Return error when queued
b72d2aa 
Change-Id: Ia4933278dba561697abccff8a6e0bc8ab0b98cc4
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 30, 2022
@k8s-ci-robot k8s-ci-robot requested a review from davidz627 March 30, 2022 22:20
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saikat-royc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from jingxu97 March 30, 2022 22:20
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2022
@saikat-royc saikat-royc requested review from mattcary and removed request for davidz627 and jingxu97 March 30, 2022 22:21
@saikat-royc saikat-royc merged commit 11e2389 into kubernetes-sigs:release-999.0 Mar 30, 2022
@mattcary mattcary mentioned this pull request May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcary mattcary Awaiting requested review from mattcary

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saikat-royc @k8s-ci-robot @mattcary