Skip to content

Add support for NVMe to NodePublishVolume #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2022
Merged

Add support for NVMe to NodePublishVolume #933

merged 1 commit into from
Mar 22, 2022

Conversation

pwschuurman
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it: This PR adds support for NVMe persistent disks to GCP PD CSI Driver. Currently only SCSI disks are supported.

Does this PR introduce a user-facing change?:

Add support for NVMe persistent disks

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 17, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @pwschuurman. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2022
@pwschuurman
Copy link
Contributor Author

pwschuurman commented Mar 17, 2022 •
edited
Loading

/cc @saikat-royc

@mattcary
Copy link
Contributor

/okay-to-test

mattcary
mattcary reviewed Mar 17, 2022
View reviewed changes
mattcary
mattcary reviewed Mar 17, 2022
View reviewed changes
pkg/mount-manager/device-utils.go Outdated
@@ -134,9 +145,58 @@ func parseScsiSerial(output string) (string, error) {
return substrings[1], nil
}

// getScsiSerial calls google_nvme_id on the given devicePath to get the serial
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/getScsiSerial/getNvmeSerial/g

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching. Updated.

@mattcary
Copy link
Contributor

lgtm modulo a nit

@mattcary
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 21, 2022
@pwschuurman pwschuurman force-pushed the add-nvme-verify-support branch from 01a7ba2 to b614d93 Compare March 21, 2022 20:16
mattcary
mattcary approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@mattcary mattcary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 09ff4a0 into kubernetes-sigs:master Mar 22, 2022
This was referenced Mar 25, 2022
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request Mar 28, 2022
@k8s-ci-robot
Merge pull request #946 from pwschuurman/automated-cherry-pick-of-#900-…
73ed381 
…#933-upstream-release-1.4

Automated cherry pick of #900: add nvme script and rules
#933: Add support for NVMe NodePublishVolume
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcary mattcary mattcary approved these changes

@saad-ali saad-ali Awaiting requested review from saad-ali

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

Assignees

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwschuurman @k8s-ci-robot @mattcary