Skip to content

Add disk image snapshot support #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2022
Merged

Add disk image snapshot support #926

merged 1 commit into from
Mar 18, 2022

Conversation

luohao
Copy link
Contributor

@luohao luohao commented Mar 10, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:
fixes
Which issue(s) this PR fixes:

Fixes #924

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add parameters to VolumeSnapshotClass for disk image config.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 10, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 10, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: luohao / name: Hao Luo (8113c53)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 10, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @luohao!

It looks like this is your first PR to kubernetes-sigs/gcp-compute-persistent-disk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gcp-compute-persistent-disk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 10, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @luohao. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 10, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 10, 2022
@luohao luohao marked this pull request as ready for review March 10, 2022 08:48
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2022
@k8s-ci-robot k8s-ci-robot requested a review from davidz627 March 10, 2022 08:49
@luohao luohao mentioned this pull request Mar 10, 2022
Closed
@mattcary
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2022
mattcary
mattcary reviewed Mar 10, 2022
View reviewed changes
pkg/common/utils.go Outdated
splitId := strings.Split(id, "/")
if len(splitId) != snapshotTotalElements {
return "", "", fmt.Errorf("failed to get id components. Expected projects/{project}/global/snapshot/{name}. Got: %s", id)
return "", "", "", fmt.Errorf("failed to get id components. Expected projects/{project}/global/snapshot/{name}. Got: %s", id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update error message to something like "expected projects/{project}/global/{snapshots|images}/{name}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks!

@mattcary
Copy link
Contributor

/assign @amacaskill

Alexis, can you look at this? You're most familiar with our volume cloning code.

Note that Han & I agreed offline about removing the paging for listing snapshots (& disk images). We ended up doing a similar thing in the filestore driver. The consumer of ListSnapshots just concatenates all the pages together anyway, so it makes it much easier to combine the disk & snapshot lists if we don't try to maintain the paging too.

@luohao luohao force-pushed the hluo/image-support branch from 8113c53 to 08422ac Compare March 10, 2022 19:49
amacaskill
amacaskill reviewed Mar 10, 2022
View reviewed changes
pkg/gce-pd-csi-driver/controller.go Outdated
@@ -22,6 +22,8 @@ import (
"strings"
"time"

"github.com/golang/protobuf/ptypes/timestamp"

Copy link
Member

@amacaskill amacaskill Mar 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove extra blank line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

amacaskill
amacaskill reviewed Mar 10, 2022
View reviewed changes
pkg/gce-cloud-provider/compute/gce-compute.go Outdated
case common.DiskImageType:
diskToCreate.SourceImage = snapshotID
default:
return fmt.Errorf("invalid snapshot tyep in snapshot ID: %s", snapshotType)
Copy link
Member

@amacaskill amacaskill Mar 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: type not tyep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@amacaskill
Copy link
Member

amacaskill commented Mar 10, 2022 •
edited
Loading

LGTM! I just had two small nits to fix.

@luohao luohao force-pushed the hluo/image-support branch from 08422ac to 25be424 Compare March 15, 2022 19:58
@luohao
Copy link
Contributor Author

luohao commented Mar 15, 2022

/retest

@mattcary
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luohao, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6e70a04 into kubernetes-sigs:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcary mattcary mattcary left review comments

@amacaskill amacaskill amacaskill left review comments

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

@davidz627 davidz627 Awaiting requested review from davidz627

Assignees

@mattcary mattcary

@amacaskill amacaskill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support disk image snapshots
4 participants
@luohao @k8s-ci-robot @mattcary @amacaskill