-
Notifications
You must be signed in to change notification settings - Fork 159
fixes kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#913 #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#913 #914
Conversation
|
Welcome @damien75! |
Hi @damien75. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
df09b76
to
2dae12f
Compare
/ok-to-test |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L#180 $SNAPSHOT_ID
should be SNAPSHOT_NAME
L#173 should be VolumeSnapshotContent
instead of VolumeSnapshotContents
LGTM, please squash your commits as well :) |
d43799a
to
8cd0d5d
Compare
Thanks for reviewing Leiyi! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damien75, mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note none |
/release-note-none |
What type of PR is this?
What this PR does / why we need it: this fixes a documentation that doesn't accomplish the goal of creating a volume snapshot from an existing snapshot
Which issue(s) this PR fixes: Fixes #913
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: NONE