Unify the build/test strategy of OSS GCE PD CSI Driver for Linux and Windows #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
mauriciopoppe
force-pushed
the
use-compiled-binaries
branch
from
1a2b5eb to
a4b11f0
Compare
mattcary
reviewed
Jan 14, 2022
test/k8s-integration/cluster.go
Outdated
| @@ -98,6 +100,14 @@ func clusterUpGCE(k8sDir, gceZone string, numNodes int, imageType string) error | |||
| return err | |||
| } | |||
|
|
|||
| // the chain is NUM_WINDOOWS_NODES -> --num-windows-nodes -> NUM_WINDOWS_NODES | |||
mauriciopoppe
force-pushed
the
use-compiled-binaries
branch
2 times, most recently
from
defb219 to
bc4fcc6
Compare
|
/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 |
1 similar comment
|
/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 |
Please keep this commit as reference
mauriciopoppe
force-pushed
the
use-compiled-binaries
branch
from
bc4fcc6 to
35cce11
Compare
|
/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 |
1 similar comment
|
/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 |
|
/hold cancel Verified that pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019 succeeded |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
Unifies the build/test strategy of OSS GCE PD CSI Driver for Linux and Windows
Implementation steps:
--kube-version=master --bringup-cluster=true --teardown-cluster=true, that way the k8s-integration binary will download and compile the kubernetes codebase, bringup and teardown the cluster.Next steps:
Which issue(s) this PR fixes:
Another step to fix #892
Does this PR introduce a user-facing change?:
/hold
/cc @mattcary @jingxu97