Skip to content

Move readonly from dev to base #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Move readonly from dev to base #886

merged 1 commit into from
Jan 7, 2022

Conversation

lizhuqi
Copy link
Contributor

@lizhuqi lizhuqi commented Jan 6, 2022

What type of PR is this?
/kind bug

What this PR does / why we need it:
Readonly shall be added to base but not dev so moving it to base in this PR.
Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Mark read-only volumes at provision time.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 6, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @lizhuqi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2022
@lizhuqi
Copy link
Contributor Author

lizhuqi commented Jan 6, 2022

/assign @mattcary
/assign @leiyiz

@k8s-ci-robot
Copy link
Contributor

@lizhuqi: GitHub didn't allow me to assign the following users: leiyiz.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @mattcary
/assign @leiyiz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mattcary
Copy link
Contributor

mattcary commented Jan 6, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. labels Jan 6, 2022
@mattcary
Copy link
Contributor

mattcary commented Jan 6, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lizhuqi, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
@lizhuqi
Copy link
Contributor Author

lizhuqi commented Jan 6, 2022

Error:
I0106 23:06:42.348] Waiting for driver to start
I0106 23:06:42.349] [/go/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/deploy/kubernetes/wait-for-driver.sh]
W0106 23:07:12.329] error: timed out waiting for the condition on deployments/csi-gce-pd-controller
I0106 23:07:12.430] Deleting driver

It seems that driver failed to start

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2022
@@ -4,7 +4,7 @@ metadata:
name: imagetag-csi-provisioner
imageTag:
name: k8s.gcr.io/sig-storage/csi-provisioner
newTag: "v2.2.1"
newTag: "v3.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, thanks, I forgot there was a version update.

@mattcary
Copy link
Contributor

mattcary commented Jan 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6d08ba8 into kubernetes-sigs:master Jan 7, 2022
k8s-ci-robot added a commit that referenced this pull request Jan 8, 2022
Cherry Pick #886 [Move readonly from dev to base] to release-1.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants