-
Notifications
You must be signed in to change notification settings - Fork 159
Move readonly from dev to base #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @lizhuqi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lizhuqi: GitHub didn't allow me to assign the following users: leiyiz. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lizhuqi, mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Error: It seems that driver failed to start |
@@ -4,7 +4,7 @@ metadata: | |||
name: imagetag-csi-provisioner | |||
imageTag: | |||
name: k8s.gcr.io/sig-storage/csi-provisioner | |||
newTag: "v2.2.1" | |||
newTag: "v3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, thanks, I forgot there was a version update.
/lgtm |
Cherry Pick #886 [Move readonly from dev to base] to release-1.4
What type of PR is this?
/kind bug
What this PR does / why we need it:
Readonly shall be added to base but not dev so moving it to base in this PR.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: