-
Notifications
You must be signed in to change notification settings - Fork 159
Add guest-configs to go.mod #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @lizhuqi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @mauriciopoppe |
hey @lizhuqi, how is this dependency used in the driver? |
/ok-to-test |
/release-note-none /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lizhuqi, mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mauriciopoppe , I plan to use the google_nvme_id script in the guest config repro to fetch unique ID of a NVMe disk for the udev issue validation. |
I see, if you want this file https://github.com/GoogleCloudPlatform/guest-configs/blob/master/src/lib/udev/google_nvme_id I think it should be added in this PR after running |
I just ran 'go mod vendor' and 'git add --force vendor' but no changes happens. |
I read that |
I see. Thanks! |
What type of PR is this?
/kind feature
What this PR does / why we need it:
To support symlink validation for NVMe, we need the google_nvme_id scripts and rules from GCP guest configs repro. This PR is to add the guest configs repro as dependency. Will upload the script and rules to pd csi driver image in next PR.