Skip to content

Add guest-configs to go.mod #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Add guest-configs to go.mod #876

merged 1 commit into from
Jan 6, 2022

Conversation

lizhuqi
Copy link
Contributor

@lizhuqi lizhuqi commented Dec 10, 2021

What type of PR is this?
/kind feature

What this PR does / why we need it:
To support symlink validation for NVMe, we need the google_nvme_id scripts and rules from GCP guest configs repro. This PR is to add the guest configs repro as dependency. Will upload the script and rules to pd csi driver image in next PR.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 10, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @lizhuqi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 10, 2021
@lizhuqi
Copy link
Contributor Author

lizhuqi commented Dec 10, 2021

/cc @mauriciopoppe

@mauriciopoppe
Copy link
Member

hey @lizhuqi, how is this dependency used in the driver?

@mauriciopoppe
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2022
@mattcary
Copy link
Contributor

mattcary commented Jan 6, 2022

/release-note-none

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 6, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lizhuqi, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
@lizhuqi
Copy link
Contributor Author

lizhuqi commented Jan 6, 2022

hey @lizhuqi, how is this dependency used in the driver?

Hi @mauriciopoppe , I plan to use the google_nvme_id script in the guest config repro to fetch unique ID of a NVMe disk for the udev issue validation.

@mauriciopoppe
Copy link
Member

I see, if you want this file https://github.com/GoogleCloudPlatform/guest-configs/blob/master/src/lib/udev/google_nvme_id I think it should be added in this PR after running go mod vendor with git add --force vendor

@lizhuqi
Copy link
Contributor Author

lizhuqi commented Jan 6, 2022

I see, if you want this file https://github.com/GoogleCloudPlatform/guest-configs/blob/master/src/lib/udev/google_nvme_id I think it should be added in this PR after running go mod vendor with git add --force vendor

I just ran 'go mod vendor' and 'git add --force vendor' but no changes happens.

@mauriciopoppe
Copy link
Member

I just ran 'go mod vendor' and 'git add --force vendor' but no changes happens.

I read that go mod vendor might not be pulling non-go files golang/go#26366 (comment), if you need the script in the image then you might need to add it to the image as a static file copied from the Dockerfile

@k8s-ci-robot k8s-ci-robot merged commit 78aa30c into kubernetes-sigs:master Jan 6, 2022
@lizhuqi
Copy link
Contributor Author

lizhuqi commented Jan 6, 2022

I just ran 'go mod vendor' and 'git add --force vendor' but no changes happens.

I read that go mod vendor might not be pulling non-go files golang/go#26366 (comment), if you need the script in the image then you might need to add it to the image as a static file copied from the Dockerfile

I see. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants