pdcsi rox workflow fix

[leiyiz]

turn on controller-publish-readonly flag and add validation in pd-csi driver for when readonly is on

if mounting a read-only ext3 or ext4 disk, use noload to prevent mount failure caused by journal replay

What type of PR is this?
/kind feature

What this PR does / why we need it:
when ROX accessMode is specified, csi.Readonly is currently not set. this PR fix that, and at the same time validate that a content source is set when readonly modes are specified at provision time.

Which issue(s) this PR fixes:

Fixes #872

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Dynamically provisioning for Read only PVs will fail now unless a volume source (either restore from snapshot or volume cloning) is specified. 

[k8s-ci-robot]

Hi @leiyiz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[verult]

/ok-to-test

[mattcary]

/approved
/lgtm

[mattcary]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leiyiz, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mattcary]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[leiyiz]

/hold
repro of #872 shows that creating from snapshot either don't have filesystem copied over, or filesystem is not correctly recognized by mounter. hold until we figure things out more

[leiyiz]

either don't have filesystem copied over, or filesystem is not correctly recognized by mounter. hold until we figure things out more

actually it's not issue with filesystem not there, mounter is not trying to setup a new filesystem. the mount failed at mount step with cannot mount /dev/sdb read-only.

[leiyiz]

/hold cancel

[mattcary]

Can you enumerate what overlays we use in upstream testing (both presubmit & periodic) & internally?

I'm wondering if we want to change stable-master now, or wait until this bakes, but I forget which test jobs use which overlay.

[leiyiz]

Internally most prow tests are using stable-master, a few are using prow-gke-release-staging-head and prow-gke-release-staging-rc-master.

Upstream postsubmits are using stable-master and dev overlays

[mattcary]

/lgtm

Okay. Let's let this run through the postsubmits using dev, then in a day or two when we see things are green you can push a PR to update stable-master?

[leiyiz]

migration testgrid is red but the driver latest grid looks green with csi-provisioner v3.0.0 picked up.